Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimony: implements hook index #338

Merged
merged 4 commits into from
Jan 7, 2025
Merged

nimony: implements hook index #338

merged 4 commits into from
Jan 7, 2025

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Jan 6, 2025 •
edited
Loading

  • createIndex
  • readIndex

image

@ringabout ringabout marked this pull request as ready for review January 6, 2025 13:53
Araq
Araq reviewed Jan 6, 2025
View reviewed changes
src/lib/nifindexes.nim Outdated

for value in values:
let (obj, sym) = value
let diff = symToOffsetMap[sym] - symToOffsetMap[obj]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not how these diffs work. But you can just store this offset as it is without any diffing this time.

@Araq Araq merged commit 92c785f into master Jan 7, 2025
3 checks passed
@Araq Araq deleted the pr_index_tags branch January 7, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq